Skip to content

[SPARK-5275] [Streaming] include python source code#4128

Closed
davies wants to merge 2 commits intoapache:masterfrom
davies:build_streaming2
Closed

[SPARK-5275] [Streaming] include python source code#4128
davies wants to merge 2 commits intoapache:masterfrom
davies:build_streaming2

Conversation

@davies
Copy link
Contributor

@davies davies commented Jan 21, 2015

Include the python source code into assembly jar.

cc @mengxr @pwendell

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25858 has started for PR 4128 at commit 48859b2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25858 has finished for PR 4128 at commit 48859b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25858/
Test PASSed.

pwendell
pwendell reviewed Jan 21, 2015
View reviewed changes
streaming/pom.xml Outdated
Copy link
Contributor

@pwendell pwendell Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be indented another level?

@pwendell
Copy link
Contributor

pwendell commented Jan 21, 2015

LGTM with just one minor style comment. @davies I'm assuming you tested this?

@davies
Copy link
Contributor Author

davies commented Jan 21, 2015

@pwendell I'm working on double-check it.

What's the purpose of include the python file into assembly jar? Those are already included in bin-package, also we didn't include the python files in assembly jar generated by sbt/sbt assembly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25875 has started for PR 4128 at commit 546af4c.

  • This patch merges cleanly.

@davies
Copy link
Contributor Author

davies commented Jan 21, 2015

@pwendell I had confirmed that these files will be included in ./dist/lib/spark-assembly-XXX-SNAPSHOT-hadoop.jar

@pwendell
Copy link
Contributor

pwendell commented Jan 21, 2015

Thanks Davies, I'm merging this.

asfgit pushed a commit that referenced this pull request Jan 21, 2015
@pwendell
[SPARK-5275] [Streaming] include python source code
410b908 
Include the python source code into assembly jar.

cc mengxr pwendell

Author: Davies Liu <davies@databricks.com>

Closes #4128 from davies/build_streaming2 and squashes the following commits:

546af4c [Davies Liu] fix indent
48859b2 [Davies Liu] include python source code

(cherry picked from commit bad6c57)
Signed-off-by: Patrick Wendell <patrick@databricks.com>
@asfgit asfgit closed this in bad6c57 Jan 21, 2015
@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25875 has finished for PR 4128 at commit 546af4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25875/
Test PASSed.

bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 22, 2015
@bomeng
[SPARK-5275] [Streaming] include python source code
95a3719 
Include the python source code into assembly jar.

cc mengxr pwendell

Author: Davies Liu <davies@databricks.com>

Closes apache#4128 from davies/build_streaming2 and squashes the following commits:

546af4c [Davies Liu] fix indent
48859b2 [Davies Liu] include python source code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davies @SparkQA @AmplabJenkins @pwendell